Cog icon indicating copy to clipboard operation
Cog copied to clipboard

Update vgmstream to r1896

Open faxx1080 opened this issue 1 year ago • 6 comments

Imports changes from r1896 of vgmstream.

I manually went through each file to find cases where the headers change slightly. I've tested on Zelda, Sonic, Metroid but not too many games.

faxx1080 avatar Jan 20 '24 17:01 faxx1080

I mean, sure, I could import this, but I won't have anything to produce new builds with.

kode54 avatar Jan 20 '24 21:01 kode54

I'm not sure what you mean by that?

faxx1080 avatar Jan 21 '24 13:01 faxx1080

Also, why did you do this manually? My regular process would have been to format-patch the upstream repository and apply the patches, modifying the code as necessary where the patches fail.

kode54 avatar Jan 21 '24 20:01 kode54

Ahh, because I was still unfamiliar with the macOS edits to vgmstream; and of the build process. The patches looked old (they had dates of 2018) and being used to repos with lots more aged code, I wasn't sure it would work.

That and I was personally impatient myself and wanted to challenge myself to "fix things myself" so I could get Sonic Superstars HCA files working. Once I did, thought it'd be a good idea to contribute back to upstream.

faxx1080 avatar Jan 21 '24 23:01 faxx1080

I have updated past the snapshot you updated to, but in a branch. It would be most helpful if you could update the libvgmstream project file to include the new files, and reference the renames contained within the commit. There is also a new directory, src/coding/libs that needs its two files added to the project. I will merge the result once tests complete.

However, I don't have a modern Mac to build for the App Store, so there won't be any binary updates for a few months, at least.

kode54 avatar Jan 22 '24 02:01 kode54

By the way, for the future reference, format-patch generation should work from the last merged commit hash, which is on the long form version tag that I include with each update to vgmstream.

kode54 avatar Jan 24 '24 07:01 kode54