Cog icon indicating copy to clipboard operation
Cog copied to clipboard

Recent "MP3" crash with Andrew Padlock Summer Mashup Pack 2K22

Open kode54 opened this issue 1 year ago • 0 comments

This mashup pack exposed numerous bugs with multiple parts of the player. For one thing, the majority of these .mp3 files are actually pre-decoded WAV files with a .mp3 extension, so I had to add a bodge for that. For two, most of them also had WAV chapters, so I had to add a bodge to the .CUE sheet chapter loader to drop to the next container loader if the file has no embedded cuesheet tag.

I also had to remove a line from the MAD Decoder cleanup code, so it doesn't close its source files, since it doesn't open them in the first place. This prevents the recycled file from crashing in the next input where it would be used in a closed state, by using stdio calls on a NULL file descriptor. Oops.

This led to about a dozen crashes by the person trying to play this downloaded album (From SoundCloud, though it's missing two of the tracks.) and trying to play it repeatedly.

The next release after 2672, likely 2677, possibly higher, will fix all of these recent crashes.

kode54 avatar Aug 04 '22 04:08 kode54