Zhisheng Huang

Results 25 comments of Zhisheng Huang

Could u rebase onto the latest master and run "./script/setup.sh" again? Then request merge again, thanks!

wow, this change is awesome that we removed the need to use spm/ folder and the generation script. I would love to get @3a4oT to take a look as well...

> DISABLED_, do we have to keep them? I think those are flaky tests and we have internal CI to auto-prefix with `DISABLED_` to disable the test, the solution should...

hey @nurdinjaelani100 what is this chek used for? and can you sign the CLA ? thx

+1 to ask the question in English, also would appreciate if you can provide some demo mode so that we can help. The gesture handling is tricky since any view...

@tarbayev Can you rebase again onto the latest master? I am having issue importing this PR, thanks!

OMG I had exact issue that @Bruce-pac experienced before: https://github.com/Instagram/IGListKit/issues/1368#issuecomment-696529398 this is what I am trying, maybe we cannot go around the Apple's setting to require "XXX.h" format instead of...

hey @jjbourdev , thanks for the PR! mind rebase from master and trigger the build again? thx!

Hey hey, thanks for working on this! I also tried out a bit but couldn't figure out how to go around the file structure thing. Looks like your latest approach...

> BTW. do you trigger CI manually? @3a4oT I think one issue I saw might be related here is that the PR is in "Draft" mode, thus it doesn't trigger...