laravel-actions icon indicating copy to clipboard operation
laravel-actions copied to clipboard

Published 20 hours ago • verified publisher icon lorisleiva

CreatesMatchingTest not found

Open soipo opened this issue 2 years ago • 2 comments

Hi there, it seems like the CreatesMatchingTest has been removed, I am unable to update my dependencies.

`Trait "Illuminate\Console\Concerns\CreatesMatchingTest" not found

at vendor/lorisleiva/laravel-actions/src/Console/MakeActionCommand.php:8 4▕ 5▕ use Illuminate\Console\Concerns\CreatesMatchingTest; 6▕ use Illuminate\Console\GeneratorCommand; 7▕ ➜ 8▕ class MakeActionCommand extends GeneratorCommand 9▕ { 10▕ use CreatesMatchingTest; 11▕ 12▕ protected $name = 'make:action'; `

Any suggestion ? Perhaps using CallsCommands in stead ?

soipo avatar Mar 10 '22 20:03 soipo

https://github.com/lorisleiva/laravel-actions/compare/main...soipo:patch-1

soipo avatar Mar 10 '22 20:03 soipo

Same problem here.. using version 2.4.0

Downgrade to 2.2.0 works for now

renepardon avatar May 02 '22 05:05 renepardon

Hi there 👋

Is this still an issue? If so, could you please open a PR? 🙏

lorisleiva avatar Dec 09 '22 10:12 lorisleiva

main...soipo:patch-1

@lorisleiva doesn’t this one fix it?

renepardon avatar Dec 09 '22 10:12 renepardon

Well, I'm not entirely sure this change fixes the described issue as it replaces a trait with a completely different one.

Additionally, it doesn't seem like the CreatesMatchingTest trait has been removed from the framework. If it was, the tests should fail as they run for both the earliest and latest version possible within the provided range.

Would you be able to provide steps to reproduce the issue?

lorisleiva avatar Dec 09 '22 10:12 lorisleiva