for windows not work

[zodman]

https://github.com/lorien/user_agent/blob/9af2d1a243338d667027491da67d75a4545ef84e/user_agent/device.py#L7

SMARTPHONE_DEV_IDS = json.load(open(os.path.join(
    PACKAGE_DIR, 'data/smartphone_dev_id.json')))

this path on windows didnt exists

correct way:

SMARTPHONE_DEV_IDS = json.load(open(os.path.join(
    PACKAGE_DIR, 'data','smartphone_dev_id.json')))

[lorien]

What windows and python versions? I run tests on appveyor platform (windows) and they pass: https://ci.appveyor.com/project/lorien/user-agent Could you provide minimal code that does not work?

[lorien]

No answer. Closing.

[MCTRACO]

having problems with this also using pyinstaller on windows

[sc0ned]

also having issues with this using pyinstaller on windows

[Aleksandr66]

Подтверждаю выше сказанное, с pyinstaller есть такая проблема досихпор

[HamerLolKekChegoo]

До сих пор есть такая проблема

[lorien]

@HamerLolKekChegoo @Aleksandr66 @sc0ned

Does pyinstaller works correctly with a fix suggesed in 1 message https://github.com/lorien/user_agent/issues/27#issue-323050178 ?

[HamerLolKekChegoo]

@lorien If I understand correctly, this should be inserted into the working file?

[lorien]

You need to clone repository, apply fix to source code, then use patched user_agent library with pyinstaller.

[lorien]

Hello guys. I have changed the way of loading package data. No data is loaded with "pkgutil.get_data()" function. That possibly fixes pyinstaller issue. Please test pyinstaller with recent version of user_agent in githu repo. I have not uploaded new package to pypi yet.

[Venon282]

someone find how fixe this please ? SMARTPHONE_DEV_IDS = json.load(open(os.path.join( PACKAGE_DIR, 'data/smartphone_dev_id.json')))

[lorien]

@Venon282 try to use latest version of user_agent from repository, I have changed there the method of loading data from JSON files. This change is not released yet as pypi package.

[Venon282]

Could you tell me how you did please ? I don't use user_agent but i have this problem on my own application

[lorien]

@Venon282 I have no idea what you are talking about.