Daniel Loreto
Daniel Loreto
@sakopov Thanks for sharing! Are you open to contributing the above code back to the project under the Apache license? (If yes, I'll put together a PR based on it)
Thank you @sjakos for sending https://github.com/jetify-com/opensource/pull/363 Just tagging it here so that the issue has a link to the PR discussion.
@hkeide thanks for pointing this out. I've created a PR that fixes the empty string bug, and adds an `IsZero` method: https://github.com/jetify-com/opensource/pull/352 Once we merge that, the next version of...
@hkeide Note that as I'm implementing it, IsZero returns true if the _suffix_ is zero _regardless_ of the prefix. In other words, all of these values would return `IsZero() ==...
One last thing. I'll point out that before my PR, you can still create a zero ID yourself by using an empty TypeID struct. For example: https://go.dev/play/p/KDqJUPhjve4
The database question is interesting – I don't know if there's an obvious "right way". While in some ways it's nice to treat the empty string as zero, it also...
@rrrodzilla Thanks for putting together this crate. It looks great. Two quick thoughts: 1. In the crate's README (https://crates.io/crates/mti) the link to `Jetify` is `jetify.io` but that's a dead page,...
@dudicoco I like this idea, let me discuss with the team to see what version we can prioritize it for
Not yet, sorry that it's taken a while. We've had to prioritize other issues. Adding @Lagoja who plans our releases so he can figure out where to schedule it.
Hi @kadaan, I was just automatically closing PRs older than 4 months (since most of them are abandoned) without making any judgement (or reading) any particular PR. For this one...