NLog.Mongo icon indicating copy to clipboard operation
NLog.Mongo copied to clipboard

Target does not update on LogManager.ReconfigExistingLoggers();

Open bobcat1506 opened this issue 5 years ago • 1 comments

We store our connection strings and credentials outside of our app in a secrets vault, but we like to keep the rest of our config in config files. We marry the two just before starting up the app. The following code works great with other targets such as the DatabaseTarget, but doesn't work with MongoTarget.

    static void Main(string[] args)
    {
        Logger logger = NLog.LogManager.GetCurrentClassLogger();

        // do startup activities like building the host and log to files
        try
        {
            // build host
        }
        catch (Exception ex)
        {
            // logger.LogException()
            // the logger never writes anything to mongo and never throws an error
        }

        // set connection string after retrieving username/password from secrets store
        var mongo = LogManager.Configuration.FindTargetByName("mongoCustom") as MongoTarget;
        mongo.ConnectionString = "mongodb://localhost/Logging";
        LogManager.ReconfigExistingLoggers();

        // run the host
        try
        {
            // host.Run()
        }
        catch (Exception ex)
        {
            // logger.LogException()
        }
    }

<target xsi:type="Mongo" name="mongoCustom" includeDefaults="false" collectionName="CustomLog" cappedCollectionSize="26214400">

bobcat1506 avatar Jun 19 '20 17:06 bobcat1506

Think it will work if you just provide a "dummy"-value for connectionString like this:

<target xsi:type="Mongo" name="mongoCustom" includeDefaults="false" collectionName="CustomLog" cappedCollectionSize="26214400" connectionString="NotReadyYet">

When Mongo-Target initializes then it validates if connnectionString contains an non-empty value. If the value is empty then the Mongo-Target throws an exception, and the Mongo-Target goes into disabled state (Stays disabled even after having updated ConnectionString-property).

Alternative solution is doing this:

mongo.ConnectionString = "mongodb://localhost/Logging";
LogManager.Configuration = LogManager.Configuration; // Close all targets and initialize them again

But it can have side-effects, and might not work with all custom NLog-targets

snakefoot avatar Jun 20 '20 20:06 snakefoot