precommit icon indicating copy to clipboard operation
precommit copied to clipboard

Support --root for more hooks

Open TNonet opened this issue 3 years ago • 2 comments

See: https://github.com/lorenzwalthert/precommit/pull/432

I seem to get a docopt issue when specifying an option without any arguments. See: https://github.com/lorenzwalthert/precommit/issues/429#issuecomment-1179806044. Therefore, I added <_ignored>... arguments as a workaround. I bet there is a better solution, but I wanted to get this initial commit out quickly.

I am unsure what is wrong with my new roxygenize tests.

TNonet avatar Aug 10 '22 13:08 TNonet

@lorenzwalthert, I can't seem to assign reviewers.

TNonet avatar Aug 10 '22 13:08 TNonet

ok @TNonet I think I found the problem. Quite annoying combination of here::here() as the default value for root (after setwd()`, it's not updated) and some weird {git2r} behaviour. Anyways, let's see if checks pass. Do you want to update the docs in the meantime? I.e. NEWS.md and the vignette on available hooks.

lorenzwalthert avatar Aug 13 '22 17:08 lorenzwalthert