audit-stash
audit-stash copied to clipboard
PHP 8.1 while maintaining PHP 7.2 & 7.3 compatibility
I think that in SerializableEventTrait.php
in serialize
and unserialize
methods you could call __serialize
and __unserialize
reducing duplicated code
/**
* Returns the string representation of this object.
*
* @return string
*/
public function serialize()
{
return $this->__serialize();
}
/**
* Takes the string representation of this object so it can be reconstructed.
*
* @param string $data serialized string
* @return void
*/
public function unserialize($data)
{
$this->__unserialize($data);
}
@gildonei done ;)
@lorenzo - can this get merged ?
Is there anything that can be done to get this merged? I have tons of logs with the following message using PHP 8.1:
AuditStash\Event\AuditUpdateEvent implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary)
Goodwill of Lorenzo to do the merge
sorry this took long
@lorenzo thanks merging. As it was Part of master shouldn't this have been tagged as 3.1.0?🤔
@lorenzo Thank you so much!
@swiffer thanks, released now
@swiffer thanks, released now
thanks!