grimd icon indicating copy to clipboard operation
grimd copied to clipboard

grimd and subdomains

Open myxalov opened this issue 9 years ago • 9 comments

Our blacklist has domains such as "*.google.com" Grimd don't understand this form as subdomains. Also if domain listed as "google.com", and domain "www.google.com" is working.

myxalov avatar Dec 26 '16 06:12 myxalov

Sorry the response has taken so long on this issue. It is a fairly annoying issue to deal with, but something I would like to fix for an upcoming release. I will look into some methods for pattern matching domain names and see what I can come up with.

looterz avatar Jul 20 '17 22:07 looterz

I have a tentative implementation. Myxalov: can you clarify what you mean with your last line: Also if domain listed as "google.com", and domain "www.google.com" is working. ? Thanks.

emdioh avatar Jul 26 '17 22:07 emdioh

#24 adds support for globs

emdioh avatar Jul 26 '17 23:07 emdioh

Sorry, I meaned that domain "www.google.com" isn't working if domain listed as "google.com".

myxalov avatar Aug 01 '17 08:08 myxalov

I see. I'm not sure that it should, though: iiuc both google.com and www.google.com are valid domain names and could correspond to different services. Would the globbing support solve your usecase?

emdioh avatar Aug 14 '17 20:08 emdioh

@emdioh @looterz I think that using .google.com should catch all while google.com should catch only google.com with a switch. to turn this function on and off.

elico avatar Feb 18 '19 10:02 elico

Is this still a issue or was it fixed with globs support?

photostorm avatar Oct 05 '19 01:10 photostorm

@looterz I have seen something interesting about such a subject: *.google.com would catch 111.google.com 11.google.com but not 1.111.google.com

And: **.google.com would catch any subdomain in any level.

What do you think? @photostorm ?

elico avatar Jul 19 '20 16:07 elico

I have "sub.abc.com" in the whilelists and "*.abc.com" in the blacklists, what would happen?

xgocn avatar Apr 20 '21 03:04 xgocn