jquery-tokeninput icon indicating copy to clipboard operation
jquery-tokeninput copied to clipboard

Fix for add token base on id - w.r.t. original file

Open prajyotsji opened this issue 11 years ago • 5 comments

prajyotsji avatar Mar 19 '15 05:03 prajyotsji

Why do you open these PR's? For what?

korun avatar Mar 19 '15 07:03 korun

@korun Hi, I'm using the js lib in one of my projects. I was facing issue with token 'C++' this works well with the forked js. But add token(append) had issue.

prajyotsji avatar Mar 19 '15 07:03 prajyotsji

So, can you provide some descriptions for your PR's? Otherwise, this PR looks quite useless, since you just removed the tokenValue option support!

korun avatar Mar 19 '15 07:03 korun

Yes, thank you for your time.

The reason to include the forked js lib was because there was no 'C++' or special characters returned in original file.

for add_token function Line : 655 - existing_data - returned me object with id and name - Object {id: "3", name: "Name"} Above is the reason to remove tokenValue and replace it with id. Thus the functionality worked.

This was just a quick fix from my side to make the js in project working and it works fine currently as per my requirement.

If you may please suggest some changes if it is not correctly done, or is there any other way I can use this plugin in my project. As the changes were made only because of 'C++'. It would be very helpful. :)

prajyotsji avatar Mar 19 '15 09:03 prajyotsji

I can't reproduce your bug. I made this jsfiddle, and, as you can see, C++ token addition with add_token function works fine. Provide your own jsfiddle example if I done some mistake.

korun avatar Mar 19 '15 11:03 korun