jquery-simple-slider icon indicating copy to clipboard operation
jquery-simple-slider copied to clipboard

Precision for output and integral tooltips for display

Open mkoistinen opened this issue 11 years ago • 1 comments

Firstly, I'm surprised this slider isn't more popular. I needed a cross-platform-capable slider for my project and looked all over. It seems my choices were: JQuery-UI (which I think is a bit heavy for a simple slider), an HTML polyfill (there are ZERO that actually work across all platforms that I could find, besides, not all projects use HTML5) or roll my own. This project is simple enough that it provided 90% of what I needed, thank you!

I see there are some pending touch-support commits, I would love to see these merged soon.

Anyway, these commits work together. First is just a removal of trailing whitespace (a pet-peeve of mine). Second is the addition of precision control for output values IF a step is defined. So, if your step is 0.01, the output will be fixed to 2 decimal places. It seems silly that this would be required, but thanks to the fuzziness of floating point numbers, it is. If no step is defined, the output is as it was: not fixed.

Finally, I've added support for an integral tooltip-style display of the output (which is one reason why the output precision was required).

mkoistinen avatar Mar 08 '13 17:03 mkoistinen

@ahmad2x4 I know we do not use more tests will now invite everyone to inciarmos tests in lib. Can you send a test?

hugohenrique avatar Feb 15 '14 02:02 hugohenrique

@ahmad2x4 ?

hugohenrique avatar Feb 21 '14 16:02 hugohenrique

What needs to be done to move this along? Being able to use a function as a source would be very beneficial. Anything I could help do to move it along would be great.

jjring avatar Apr 23 '14 14:04 jjring

@hugohenrique Sure I can provide test for this one. What is the preferred test framework. I didnt see any existing test to follow.

ahmad2x4 avatar Apr 23 '14 22:04 ahmad2x4

Hi @ahmad2x4, really does not exist test! In order to improve the quality of the plugin want to start as soon as possible, I need more for everyone's help! I think the jasmine: http://jasmine.github.io/

hugohenrique avatar Apr 23 '14 22:04 hugohenrique

I'm in you can count on me

On Thu, Apr 24, 2014 at 8:41 AM, Hugo Henrique [email protected]:

Hi @ahmad2x4 https://github.com/ahmad2x4, really does not exist test! In order to improve the quality of the plugin want to start as soon as possible, I need more for everyone's help! I think the jasmine: http://jasmine.github.io/

— Reply to this email directly or view it on GitHubhttps://github.com/loopj/jquery-tokeninput/pull/628#issuecomment-41223669 .

Ahmad Atighechi Technical Lead | MCPD | CSM

T: +61 435 918 777 E: [email protected] [email protected]

ahmad2x4 avatar Apr 23 '14 23:04 ahmad2x4