collection
collection copied to clipboard
loophp
refactor: Refactor `Reduce` operation.
BREAKING CHANGE: yes
This PR:
- [ ] Fix #256 but there are other operations to refactor.
- [x] It breaks backward compatibility
- [x] Is covered by unit tests
- [x] Has static analysis tests (psalm, phpstan)
- [x] Has documentation
- [ ] Is an experimental thing
I think I'm done with this PR, let's leave it open a little bit to carefully check if this is the proper thing to do.
I know the pace is a bit different during holidays, so, it might take a little while before it gets merged.
@AlexandruGG I think it's ready, wdyt ?
Amazing! I'll go through this today :)
@AlexandruGG I think it's ready, wdyt ?
@drupol let me know if you'd like me to help with the remaining ones :)
Thanks for the review Alex, I can continue to work on it tonight, but feel free to push things if you want to.
Thanks for the review Alex, I can continue to work on it tonight, but feel free to push things if you want to.
Sure, leave the comparison operations to me :)
I now leave this PR to you @AlexandruGG , good work !
Thanks! I added the remaining operations and updated a couple bits of documentation that were still mentioning current.
I'll give this another fresh look tomorrow, see if I can spot anything else needed.
Thanks! I added the remaining operations and updated a couple bits of documentation that were still mentioning
current.
Indeed, nice. I was planning to do it after all the commits were done, but you did it. Thanks :)
I'll give this another fresh look tomorrow, see if I can spot anything else needed.
Ok will do that ! Cheers!
@drupol I went through this again and added a few more things. Please feel free to comb through the docs yourself as well and see if you can spot any bits we might have missed
This is super great !!!
I propose to merge this, then do remaining changes if any in another branch.
We've been waiting for too long for this :)