loopback-next icon indicating copy to clipboard operation
loopback-next copied to clipboard

feat(cli): add models option in discover cli command to generate spec…

Open sohaibahsan007 opened this issue 2 years ago • 4 comments

added --models option inside lb4 discover the command to generate specific models

Fixes #7104

Checklist

  • [x] DCO (Developer Certificate of Origin) signed in all commits
  • [x] npm test passes on your machine
  • [x] New tests added or existing tests modified to cover all changes
  • [x] Code conforms with the style guide
  • [x] API Documentation in code was updated
  • [x] Documentation in /docs/site was updated
  • [x] Affected artifact templates in packages/cli were updated
  • [x] Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

sohaibahsan007 avatar May 17 '22 18:05 sohaibahsan007

Pull Request Test Coverage Report for Build 2340528877

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 76.515%

Totals Coverage Status
Change from base Build 2340239535: 0.007%
Covered Lines: 18022
Relevant Lines: 19119

💛 - Coveralls

coveralls avatar May 17 '22 18:05 coveralls

@achrinza done. please review

sohaibahsan007 avatar May 20 '22 19:05 sohaibahsan007

Please fix failing test.

achrinza avatar May 21 '22 05:05 achrinza

@achrinza: may we please ask you to having a quick look at this PR? there is an error in the build, but no error message available. Thanks for the clarification...

cloud20x avatar May 23 '22 15:05 cloud20x

@achrinza May I please ask you to get back to our question? And please add: [email protected] to this PR so he can take it forward? Thanks

cloud20x avatar Nov 07 '22 15:11 cloud20x

There hasn't been any progress from the PR creator. Can I recreate the PR referencing this PR to have this PR move forward? Or the PR can be merged without their response? @achrinza

aaqilniz avatar Nov 16 '22 16:11 aaqilniz

Closing in favor of https://github.com/loopbackio/loopback-next/pull/9092

dhmlau avatar Mar 09 '23 17:03 dhmlau