loopback-next icon indicating copy to clipboard operation
loopback-next copied to clipboard

improved Readme file passport login to add .env file and import it in application.ts file

Open hizbullaharif opened this issue 3 years ago • 1 comments

passport login has the issue of .env file and also it's import

Checklist

  • [x] DCO (Developer Certificate of Origin) signed in all commits
  • [x] npm test passes on your machine
  • [x] New tests added or existing tests modified to cover all changes
  • [x] Code conforms with the style guide
  • [x] API Documentation in code was updated
  • [x] Documentation in /docs/site was updated
  • [x] Affected artifact templates in packages/cli were updated
  • [x] Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

hizbullaharif avatar Feb 24 '22 14:02 hizbullaharif

Hi @hizbullaharif, thanks for your contribution! Unfortunately I'm not sure the purpose of dotenv in this case; The current steps state to set the environment variable, which https://github.com/loopbackio/loopback-next/issues/5876#issuecomment-663982114 explains.

As an example codebase, we want to keep it as simple as possible. IMO, adding dotenv is not necessary and will only add confusion as it raises questions like "is it necessary?" and "why is it used?", when it's not actually required. In contrast, existing OS mechanisms in of setting environment variables for Windows and *NIX are well-defined and well-documented online.

--

Please also consider reviewing:

  • https://loopback.io/doc/en/lb4/code-contrib-lb4.html#commit-message-guidelines and
  • https://loopback.io/doc/en/contrib/code-contrib.html#signing-off-commits-using-dco

on the commit message syntax and the DCO sign-off that are necessary for contributing LoopBack Git repositories.

achrinza avatar Feb 26 '22 10:02 achrinza