loopback-next icon indicating copy to clipboard operation
loopback-next copied to clipboard

Test/Enable Node.js 14 support for SQL connectors

Open dhmlau opened this issue 4 years ago • 7 comments

Originated from epic: https://github.com/strongloop/loopback-next/issues/6019

Acceptance Criteria

For the following connectors, test locally on Node.js 14 and see if all tests passed.

  • If yes, add Node.js 14 to CI
  • If not, try to fix it for simple fixes. If you don't think you can fix it in a day, open a new issue to keep track of it.

Here is the list of connectors:

SQL connectors:

  • [x] loopback-connector
  • [x] loopback-connector-mysql
  • [x] loopback-connector-postgresql
  • [x] loopback-connector-mssql
  • [ ] loopback-connector-oracle
  • [x] loopback-connector-db2 (need to find out if ibm_db supports Node.js 14)

dhmlau avatar Jul 28 '20 15:07 dhmlau

loopback-connector: PR https://github.com/strongloop/loopback-connector/pull/180.

dhmlau avatar Aug 27 '20 18:08 dhmlau

We've enabled Node.js 14 in Jenkins, so it should be part of the CI automatically. For mssql connector, CI all passes. See https://github.com/strongloop/loopback-connector-mssql/pull/233 Screen Shot 2020-10-02 at 2 26 18 PM

dhmlau avatar Oct 02 '20 18:10 dhmlau

loopback-connector-db2 has been verified as well. See https://github.com/strongloop/loopback-connector-db2/pull/152

Screen Shot 2020-10-02 at 4 52 26 PM

dhmlau avatar Oct 02 '20 20:10 dhmlau

What's left is to test loopback-connector-oracle works on Node.js 14. I believe currently there's some CI issue (not related to Node.js 14) in that repo.

dhmlau avatar Oct 22 '20 20:10 dhmlau

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

stale[bot] avatar Sep 22 '21 03:09 stale[bot]

Hi @dhmlau I am facing the same issue where I want to update the Loopback 3 node version to 14.17.1 & the latest loopback-connector-postgresql to 5.4.0, but I am facing issue saying below -

`/Users/<project_path>/node_modules/loopback-connector/lib/transaction.js:125 tx.notifyObserversOf('timeout', context, function(err) { ^

TypeError: tx.notifyObserversOf is not a function at Timeout._onTimeout (/Users/<project_path>/node_modules/loopback-connector/lib/transaction.js:125:12) at listOnTimeout (internal/timers.js:557:17) at processTimers (internal/timers.js:500:7) [nodemon] app crashed - waiting for file changes before starting...`

Any idea on how to fix this issue?

prachitin avatar Oct 18 '21 10:10 prachitin

TypeError: tx.notifyObserversOf is not a function

@prachitin have you found any solutions for this? I'm trying to update node to 16 from 12 and started to notice this when we have timeout in beginTransaction.

ghiden avatar Feb 16 '22 17:02 ghiden