loopback-next icon indicating copy to clipboard operation
loopback-next copied to clipboard

change dataSource to datasource

Open warisniz02 opened this issue 11 months ago • 4 comments

The lb4 discoverer names the argument to pass datasource as "dataSource". This PR makes the argument consistent with the lb4 datasource without breaking existing cli command 'lb4 dataSource'.

Checklist

  • [x] DCO (Developer Certificate of Origin) signed in all commits
  • [x] npm test passes on your machine
  • [x] New tests added or existing tests modified to cover all changes
  • [x] Code conforms with the style guide
  • [ ] API Documentation in code was updated
  • [ ] Documentation in /docs/site was updated
  • [ ] Affected artifact templates in packages/cli were updated
  • [ ] Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

warisniz02 avatar Mar 24 '24 13:03 warisniz02

Pull Request Test Coverage Report for Build 8738018459

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.371%

Totals Coverage Status
Change from base Build 8721360373: 0.0%
Covered Lines: 9563
Relevant Lines: 12457

💛 - Coveralls

coveralls avatar Mar 30 '24 17:03 coveralls

@dhmlau please have a look at my PR.

warisniz02 avatar Apr 18 '24 13:04 warisniz02

Hello @samarpanB. Can you please have a look at this PR?

warisniz02 avatar Jul 12 '24 06:07 warisniz02

@samarpanB please have a look at my PR!

warisniz02 avatar Aug 27 '24 06:08 warisniz02

one of the test case is failing

samarpanB avatar Sep 01 '24 15:09 samarpanB

@samarpanB, this test case fails in every PR. This PR is to fix this issue( https://github.com/loopbackio/loopback-next/pull/10634)

warisniz02 avatar Sep 04 '24 06:09 warisniz02

There seems to be some issue with the setup-node GH action, and not related to the changes introduced in this PR. So I'm going to merge this PR.

dhmlau avatar Sep 05 '24 13:09 dhmlau

@warisniz02, thanks for your contribution. Your PR has been merged! 🎉

dhmlau avatar Sep 05 '24 13:09 dhmlau