loopback-next
loopback-next copied to clipboard
change dataSource to datasource
The lb4 discoverer
names the argument to pass datasource as "dataSource". This PR makes the argument consistent with the lb4 datasource
without breaking existing cli command 'lb4 dataSource'.
Checklist
- [x] DCO (Developer Certificate of Origin) signed in all commits
- [x]
npm test
passes on your machine - [x] New tests added or existing tests modified to cover all changes
- [x] Code conforms with the style guide
- [ ] API Documentation in code was updated
- [ ] Documentation in /docs/site was updated
- [ ] Affected artifact templates in
packages/cli
were updated - [ ] Affected example projects in
examples/*
were updated
Pull Request Test Coverage Report for Build 8738018459
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 55.371%
Totals | |
---|---|
Change from base Build 8721360373: | 0.0% |
Covered Lines: | 9563 |
Relevant Lines: | 12457 |
💛 - Coveralls
@dhmlau please have a look at my PR.
Hello @samarpanB. Can you please have a look at this PR?
@samarpanB please have a look at my PR!
one of the test case is failing
@samarpanB, this test case fails in every PR. This PR is to fix this issue( https://github.com/loopbackio/loopback-next/pull/10634)
There seems to be some issue with the setup-node GH action, and not related to the changes introduced in this PR. So I'm going to merge this PR.
@warisniz02, thanks for your contribution. Your PR has been merged! 🎉