loopback-datasource-juggler icon indicating copy to clipboard operation
loopback-datasource-juggler copied to clipboard

feat: allow empty array in createAll method

Open ajay-prajapati07 opened this issue 5 months ago • 3 comments

Added code to allow empty array in createAll method. Currently it throws error.

Include references to all related GitHub issues and other pull requests, for example:

Fixes #2409 -->

Checklist

  • [ ] Sign off your commits with DCO (Developer Certificate of Origin)
  • [ ] npm test passes on your machine
  • [ ] New tests added or existing tests modified to cover all changes
  • [ ] Code conforms with the style guide
  • [ ] Commit messages are following our guidelines

ajay-prajapati07 avatar Jun 05 '25 06:06 ajay-prajapati07

Also please sign off your commit. Follow DCO here - https://loopback.io/doc/en/contrib/code-contrib.html

samarpanB avatar Jun 05 '25 18:06 samarpanB

Pull Request Test Coverage Report for Build 15629436334

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 10 (20.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 84.647%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/dao.js 2 10 20.0%
<!-- Total: 2 10
Totals Coverage Status
Change from base Build 15670951978: -0.06%
Covered Lines: 7279
Relevant Lines: 8293

💛 - Coveralls

coveralls avatar Jun 19 '25 15:06 coveralls

Can you please add a test case for this option ?

samarpanB avatar Jun 19 '25 15:06 samarpanB