loopback-connector-postgresql icon indicating copy to clipboard operation
loopback-connector-postgresql copied to clipboard

✨ Add support to query encrypted data

Open SAMIBETTAYEB opened this issue 4 years ago • 13 comments

New feature about querying encrypted fields.

SAMIBETTAYEB avatar Jun 17 '21 22:06 SAMIBETTAYEB

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

slnode avatar Jun 17 '21 22:06 slnode

You can sign the DCO by running the following command:

git commit --amend -s 

Reference: https://loopback.io/doc/en/contrib/code-contrib.html.

dhmlau avatar Jun 21 '21 17:06 dhmlau

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 21 '21 22:08 stale[bot]

Do any of the reviewers verify it, please?

SAMIBETTAYEB avatar Sep 01 '21 16:09 SAMIBETTAYEB

Hi @sam-github, could you rebase your PR against the latest copy of master? That way the CI pipeline can be triggered.

achrinza avatar Sep 02 '21 04:09 achrinza

@achrinza, done!

SAMIBETTAYEB avatar Sep 02 '21 14:09 SAMIBETTAYEB

Can any of the reviewers verify the PR, please?

SAMIBETTAYEB avatar Sep 07 '21 16:09 SAMIBETTAYEB

Apologies @SAMIBETTAYEB, I didn't realise that this PR was targeting 3.x instead of master. I'll cherry-pick the commits into new PRs.

achrinza avatar Sep 12 '21 14:09 achrinza

Thank you @achrinza, waiting for your review.

SAMIBETTAYEB avatar Sep 12 '21 14:09 SAMIBETTAYEB

Thanks, @SAMIBETTAYEB; Would you be able to point this PR to the master branch (v5.x)? Or is 3.x necessary? Based on what I can tell, 5.x supports both LB3 and LB4.

achrinza avatar Sep 12 '21 15:09 achrinza

Yep @achrinza, I think it will be.

SAMIBETTAYEB avatar Sep 12 '21 15:09 SAMIBETTAYEB

Thanks, @SAMIBETTAYEB. If you're comfortable with performing this, could you please reset the branch against master, then cherry-pick the commit range you intend to submit?

The commands should look similar to this:

$ git reset --hard upstream/master # Assuming you've set `upstream` remote to loopbackio/loopback-connector-postgresql
$ git cherry-pick 1199248a0a3e2881241e01d970bb1411605bfead...9beef0c353f335731e498fe262f6daac50012103

# Fix any merge conflicts
git add --all
git cherry-pick --continue
# Repeat last 2 steps for each commit with a merge conflict

# Push changes to remote
$ git push --force-with-lease

Please adjust the commands above according to your Git setup if necessary.

For a wrost-case scenario, I've created a 'backup' of your original commits at https://github.com/loopbackio/loopback-connector-postgresql/pull/486

achrinza avatar Sep 12 '21 16:09 achrinza

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 11 '21 16:11 stale[bot]