loomchain icon indicating copy to clipboard operation
loomchain copied to clipboard

Addresses in log messages should be human readable

Open joe-bowman opened this issue 5 years ago • 2 comments

Related to #966, Addresse values in the DPOS BeginBlock DowntimeEvidence logs, are displayed as a list of byte-values, for example:

validatorAddress="ѱ\ufffdQ3\ufffd5Jw_e\t\u001e6X\u0007\ufffd\ufffd\ufffdm"
validatorAddress="\ufffd\ufffd\ufffdh\ufffd\ufffdl\ufffd\ufffdqm\u0019\ufffd\\\ufffdΰ\ufffd\ufffd"
validatorAddress="\u0015\u000f\ufffd\ufffd\ufffd\ufffd\ufffdQ\ufffd\ufffd\u0018\ufffd\ufffd\ufffdS\u0010\ufffd؉d"

These logs should be appropriately decoded into hex addresses for log output to make parsing/reading of logs easier.

joe-bowman avatar Apr 08 '19 17:04 joe-bowman

This is likely covered by the following issue in go-loom: https://github.com/loomnetwork/go-loom/issues/244

joe-bowman avatar Apr 09 '19 10:04 joe-bowman

PR for the same which was merged earlier - https://github.com/loomnetwork/loomchain/pull/1057

suhasagg avatar Aug 08 '19 09:08 suhasagg