loomchain icon indicating copy to clipboard operation
loomchain copied to clipboard

Deprecate the conditional route handlers

Open enlight opened this issue 6 years ago • 1 comments

  • No need to unmarshal every tx multiple times to figure out if it's an EVM tx or not before it hits Call/DeployTxHandler.
  • New tx handlers always set TxHandlerResult.Info as soon as they figure out the tx type, legacy handlers didn't do so if the tx failed.
  • Cleaned up error handling a bit in the new DeployTxHandler.

Related: https://github.com/loomnetwork/go-loom/pull/478

enlight avatar Sep 23 '19 19:09 enlight

So after we activate the config, EvmTx is not going to run with loomchain.NoopTxHandler on CheckTx anymore. Need to think about how this would affect receipts and other things.

It won't affect receipts and other things because the new CallTxHandler doesn't actually run any of that code, see https://github.com/loomnetwork/loomchain/pull/1497/files#diff-141a5928106d9d5a533ebaf05559359cR49

enlight avatar Oct 02 '19 17:10 enlight