loomchain icon indicating copy to clipboard operation
loomchain copied to clipboard

Investigate Tx Hash for EVM txs

Open pathornteng opened this issue 5 years ago • 1 comments

Currently, the TX hash for a successful EVM TX is derived from EVM TX receipt passed back to TM through ResponseDeliverTx{Data: r.Data}. However, failed EVM TX does not have a receipt so the TX hash of failed EVM TX is auto-generated by TM and two failed EVM TXs can have the TX hash. In theory, the TX sender should be able to calculate TX hash (Ethereum TX hash) but right now the TX hashes are generated by WriteReceipt or TM. We have to sort things out and make our EVM behavior similar to Ethereum.

I think we should start working on issue https://github.com/loomnetwork/loomchain/issues/1398 to improve e2e test for EVM first.

pathornteng avatar Aug 14 '19 05:08 pathornteng

Our initial attempt at making the EVM tx hashes deterministic also resulted in them no longer being unique in some cases, we need to take another stab at this.

enlight avatar Oct 31 '19 11:10 enlight