loomchain icon indicating copy to clipboard operation
loomchain copied to clipboard

Published 20 hours ago • verified publisher icon loomnetwork

Split Hsm config out of loom.yml

Open atchapcyp opened this issue 6 years ago • 2 comments

Added function and test ParseConfigFileName for specify configuration file. ref #1188

  • [ ] I added unit tests for any code that added
  • [ ] I updated the CHANGELOG.md
  • [ ] All IP is original and not copied from another source
  • [ ] I assign all copyright to Loom Network for the code in the pull request

atchapcyp avatar Jun 19 '19 08:06 atchapcyp

Currently, we have duplicate ParseConfig functions, one in cmd/loom/common and another one in config/config. We should remove the one in config/config and then change this line https://github.com/loomnetwork/loomchain/blob/fe27e028672fe46a779d4dfa2c85979465d305a0/rpc/query_server.go#L158 to call ParseConfig in cmd/loom/common

pathornteng avatar Jun 19 '19 10:06 pathornteng

Currently, we have duplicate ParseConfig functions, one in cmd/loom/common and another one in config/config. We should remove the one in config/config and then change this line

https://github.com/loomnetwork/loomchain/blob/fe27e028672fe46a779d4dfa2c85979465d305a0/rpc/query_server.go#L158 to call ParseConfig in cmd/loom/common

You got that backwards, config/config should have the canonical ParseConfig, nothing should depend on cmd/loom/common outside of cmd/loom/*

enlight avatar Jun 20 '19 08:06 enlight