sdk-codegen icon indicating copy to clipboard operation
sdk-codegen copied to clipboard

Typescript is not in "devDependencies" for @looker/sdk

Open arthot opened this issue 4 years ago • 1 comments

Hi,

according to package.json files typescript and ts-node are listed in section dependencies instead of devDependencies. This bloats production installation since TS is a huge package (50MB).

    "ts-node": "^8.4.1",
    "typescript": "^3.8.2"

This especially noticeable on aws lambda where TS takes up to 90% of the whole installation. I don't know if it's a bug or a feature, but JS users would appreciate if npm ci --production doesn't install TS and doesn't bloat node_modules in production mode.

arthot avatar Aug 31 '20 13:08 arthot

The packages/sdk/package.json doesn't refer to ts-node or typescript. Perhaps it did back when you created this issue? However, I do see some cruft in that package.json file so I'll remove it. Thanks!

jkaster avatar Mar 30 '21 22:03 jkaster