Sarah Hoffmann

Results 469 comments of Sarah Hoffmann

> One question though about the 'Elasticsearch is on it's way out': I've been planning to update the Elastic client to the [Java API](https://www.elastic.co/guide/en/elasticsearch/client/java-api-client/current/index.html) so you can use an existing...

Sorry for the long delay in responding. I've decided to get a release out first before looking into this again. Because of this there is a minor merge conflict now...

> Request failed: [mapper_parsing_exception] No handler for type [geo_shape] declared on field [geometry] That's where I gave up my experiments with this branch as well. It's possible that the [embedded...

It needs to work with opensearch-runner because that is also what Photon uses in embedded mode. From the code you cite it looks like you can supply your own module...

With #855 merged you can now simply add the plugin to `build.gradle` and enable it by adding it to the list in https://github.com/komoot/photon/blob/919784fe80680631a56471b14e4648683ed568fe/app/opensearch/src/main/java/de/komoot/photon/Server.java#L36

> I have build in support for LineString and Polygons and have to analyze the Nominatim database for other Geometries. Nominatim has everything: Point, LineString, MultiLineString, Polygon, MultiPolygon. It definitely...

I'm inclined to merge this now as is. There are a few places where there is room for improvement (for example, there could be more tests) but given the size...

I've squash-merged this now as it is blocking a few other changes and I really don't want to make you go through rebasing again. There probably will be a few...

Sorry for creating the conflict. I found #816 while reviewing this PR. Please just rebase on master at some point. I don't mind force pushes to PR branches.

> Therefore fixing the filter from "no house number" to "no house number and not a house" should be sufficient. You may even want to put a global filter on...