Sarah Hoffmann

Results 469 comments of Sarah Hoffmann

On the technical side: the CI error has nothing to do with your PR. I've fixed it on master. Can you please rebase at some point. Also, the new feature...

The `lang` parameter is not defined as only changing the output language. It has always also had an influence on the ranking of search results. If that is a good...

Object with `advertising=*` are not imported at the moment. I don' t see that happen anytime soon. They are not the usual thing people search for and very rarely have...

> Shouldn't every object with a name be imported? If people mapped it with a name wouldn't it be interesting per se? Yes and no. The problem with the 'name'...

It's challenging but doable if you are not afraid to dive head-deep into pl/PgSQL code. Here are some pointers to get you started: * The basic idea would be to...

Tried this in https://github.com/lonvia/Nominatim/tree/drop-outside-address-parts-backup and it turns out to be far too slow to check for containment. This first needs a clever idea how to reduce the number of geometry...

This is a bit of an edge case to addr:* tag matching around boundaries. The matching is done on partial terms to have a bit of a fuzziness. That means...

No, sorry. The fix is a bit more involved.

You can remove this WHERE condition in your code: https://github.com/osm-search/Nominatim/blob/12a3d51bcc7b1a2aa5eb17c2b2dd36b71ae5610c/lib-sql/functions/placex_triggers.sql#L369 Reload the SQL with `nominatim refresh --function` and then you can reindex the affected addresses (`UPDATE placex SET indexed_status =...

If only one zoom level is requested for expiry, then the behavior is the same. For multiple level, people using scripts for the combined tiles will suddenly do a lot...