myth-auth icon indicating copy to clipboard operation
myth-auth copied to clipboard

fix BaseFilter not found error after publishing filters from cli

Open manageruz opened this issue 2 years ago • 5 comments

This will add 'use Myth\Auth\Filters\BaseFilter;' import to the all three filter files after publishing them by auth:publish command.

manageruz avatar Sep 22 '22 08:09 manageruz

Fixes #568

manageruz avatar Sep 22 '22 08:09 manageruz

Closes #569

manageruz avatar Sep 22 '22 08:09 manageruz

Waiting for review from @MGatner

manageruz avatar Sep 22 '22 08:09 manageruz

Here is still PHPStan and Rector errors. Extending BaseController instead of Controller will fix first one.

manageruz avatar Oct 08 '22 10:10 manageruz

Let's deal with the pipeline issues in a separate PR, then this will be much easier to pass and review. I can help with that later today, but it looks like you have a good start if you want to make a new branch and cherry-pick your commits.

MGatner avatar Oct 08 '22 10:10 MGatner