Grails 2.4.3 compatibility

[ph4t]

We get the following exception after installing the plugin:

...\spring-batch-2.0.0\grails-app\services\grails\plugins\springbatch\SpringBatchService.groovy: 248: Method 'onApplicationEvent' from class 'grails.plugins.springbatch.SpringBatchService' does not override method from its superclass or interfaces but is annotated with @Override.
 @ line 248, column 2.

Is this a known issue?

[danieldbower]

Did a little bit of research just now. I'm coding against Grails 2.2.4, but with a small timebox, I downloaded Grails 2.4.3. The Interface for ApplicationListener, which is used by the SpringBatchService appears not to have changed from the docs that I can tell, but I encountered the same error as you when I tried to install the plugin on an otherwise blank project.

I've committed the change, but not released as of yet.

You might want to checkout another branch https://github.com/xmlking/grails-spring-batch which has some additional functionality for 2.4.3. I simply don't have the cycles to invest in bringing that over currently.

[michaelbannister]

I, too, would be interested getting the plugin working with the latest Grails release.

I simply don't have the cycles to invest in bringing that over currently.

Is there anything in particular that needs doing? I'd be happy to try & help – I haven't worked on Grails plugins before but I'm always ready to learn something new :)

[danieldbower]

At this point, I think there are branches floating around with the plugin working with the latest Release. All that needs done is pulling the changes in, and pushing to the master grails plugin repository. This just involves getting the proper permissions to this repo and the grails plugin repository, and performing the push.

[johnrengelman]

@danieldbower can you post to the grails-dev Google Group requesting permissions publish permissions for this plugin? You'll need to provide 'grails.org' username. Let me know when you do, then I'll respond back approving it and they should give you access to do publications.

[danieldbower]

Request at: https://groups.google.com/d/topic/grails-dev-discuss/-T6USi6ZQRk/discussion

[johnrengelman]

Looks like it was approved.

[john-london]

@danieldbower @johnrengelman Did you have any success in publishing the 2.4.3 updates please? I see the official version plugin hasn't been updated since Sep 2014, pre-dating the fixes for the latest Grails version.

[danieldbower]

I am able to publish, but I haven't had the time/funding to properly test it before pushing. Has anyone started to run this in a Grails 2.4 environment to smoke out any bugs?

[john-london]

@danieldbower I have been using the version shown here (https://github.com/xmlking/grails-spring-batch) as mentioned in your post for 2.4.3. It seems to work ok. However, there appears to be a very nasty bug / mode of behaviour, that I expect is common to all versions, when this plugin is used in a plugin itself. Details here: https://github.com/johnrengelman/grails-spring-batch/issues/29 (I see you closed #27 as a dupe).

I'd be happy to work on a fix for this, but I'm still relatively new to Grails/Groovy. At the moment, I'm looking at ideas mentioned here: http://stackoverflow.com/questions/24028410/load-spring-beans-from-custom-groovy-files-in-grails-app.

Update: I've posted a possible fix in the comments to #29 and I'd be interested in any comments thereon (have yet to test it fully).

[danieldbower]

@john-london: With @xmlking's branch, at what commit did you pull? Have you tested the admin screens to verify they still work: being able to start/stop a job, viewing when steps last ran, etc...

[john-london]

I used the latest commit on master, but am not using (and so have not tested) any of the UI screens.