freeciv21 icon indicating copy to clipboard operation
freeciv21 copied to clipboard

Published 20 hours ago • verified publisher icon longturn

Add "Clean Nuclear Fallout" to "Unit Controls" widget

Open blabber opened this issue 10 months ago • 2 comments

fallout.svg is based on https://commons.wikimedia.org/wiki/File:Radioactive_White.svg

Closes #2273

blabber avatar Apr 11 '24 19:04 blabber

Without this PR: missing_fallout

With this PR: fallout_fixed

blabber avatar Apr 11 '24 19:04 blabber

@blabber would you pls upload the save game you have w/ fallout?

jwrober avatar Apr 11 '24 21:04 jwrober

@blabber would you pls upload the save game you have w/ fallout?

🫴 fallout.sav.xz.zip

blabber avatar Apr 12 '24 06:04 blabber

You need to add fill="#000" to the top level <svg open tag for it to work for both light and dark themes. On my local I did this

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512" fill="#000" ...

jwrober avatar Apr 13 '24 16:04 jwrober

You need to add fill="#000" to the top level <svg open tag for it to work for both light and dark themes.

I changed fallout.svg as requested, but to be honest I still don't see any difference in light and dark theme (see screenshots below). Which irritates me even more, is that other icons (for example mine.svg) don't have this fill in their opening <svg ... tag.

Screenshots

Light theme

light

Dark theme

dark

blabber avatar Apr 14 '24 19:04 blabber

Thanks for the update and submission of the icon. I am able to reproduce on my local too. I guess something is diff with how we do the unit controls bar vs other UI elements in the game that need that fill code.

jwrober avatar Apr 15 '24 12:04 jwrober