freeciv21 icon indicating copy to clipboard operation
freeciv21 copied to clipboard

Published 20 hours ago • verified publisher icon longturn

grey out the buy button on city's first turn

Open hugomflavio opened this issue 10 months ago • 2 comments

Is your feature request related to a problem? Please describe. It is not clear that cities can't buy their production on the turn they're created.

Describe the solution you'd like Grey out the buying button on the city's first turn. Add a tool-tip on hovering that explains the city can't rush production on the turn it is built (text can be flourished to look nicer e.g. "Your citizens are still busy settling down, they can't rush production this turn!")

hugomflavio avatar Mar 30 '24 15:03 hugomflavio

https://github.com/longturn/freeciv21/blob/2e8becf3955bf6b10d8b6a0f66dfa507d86256b1/client/citydlg.cpp#L1490-L1496

It looks like buy_cost comes straight from the server (and is just some very large constant when buying is not possible). I would support a patch where the server sends the "no buy" constant on the city's first turn. This way the client doesn't need to make assumptions about the rules.

lmoureaux avatar Apr 09 '24 21:04 lmoureaux

Does that mean it is time to call Wieder? :sweat_smile:

hugomflavio avatar Apr 10 '24 00:04 hugomflavio