Remove modpack installer shortcut from packages

[jwrober]

Is your feature request related to a problem? Please describe. We have recently added a button on the start screen to open the modpack installer, so we don't need windows shortcuts or .desktop files for the app any longer.

Describe the solution you'd like Remove these from the NSIS and /dist directories. Update varying installation points/packages.

Describe alternatives you've considered Can keep them, but its unnecessary icons in start menus and such.

Additional context None

[lmoureaux]

Maybe first add an item to the Game menu so one can also install modpacks during a game?

[jwrober]

That's a good idea. Easy to implement the basics, but how do we "refresh" so the client knows something changed?

[lmoureaux]

Hmm good point, currently we need to restart the game if we want to see the new modpacks. This is because get_tileset_list in tilespec.cpp uses a static vector. Removing it could affect performance so should be evaluated "carefully". I'm not sure how sound sets and music sets are discovered, maybe they already magically refresh.

[lmoureaux]

Blockers for this have been addressed. Will we still need a modpack installer icon after all? :sweat_smile:

[jwrober]

Yep, just don't need a "start menu" type icon.

[lmoureaux]

Note that on Wayland window icons are tied to desktop files, so we'll lose the modpack installer icon on Wayland if we remove the .desktop. Maybe it's possible to have desktop files that are not in the menu though.