freeciv21 icon indicating copy to clipboard operation
freeciv21 copied to clipboard

Allies only option not styled properly when checked

Open psampathkumar opened this issue 2 years ago • 6 comments

Describe the bug The popup for the allies only checkbox always shows, "allies only". It is confusing given it isnt a check but has a icon change currently.

To Reproduce Steps to reproduce the behavior:

  1. Open a game.
  2. Hover over allies only checkbox in chat widget

Expected behavior The popup should say "broadcast globally" (or something along those lines), when allies only is enabled, and "allies only" when allies only is disabled. So that the user understands what that option goes.

Screenshots image image

Platform and version (please complete the following information):

  • master

psampathkumar avatar Jul 19 '22 18:07 psampathkumar

Expected behavior The popup should say "broadcast globally" (or something along those lines), when allies only is enabled, and "allies only" when allies only is disabled. So that the user understands what that option goes.

Do you mean to say that when "Allies Only" is enabled the tool tip should say so and when disabled the tool tip would say "broadcast to all" or something?

jwrober avatar Jul 19 '22 20:07 jwrober

That or the other way around. Both works, like to show, "allies only" is enabled. Or to show, clicking on it will change to allies only. I am not really sure which way is better, but it should definitely be one of the two to keep things consistent.

psampathkumar avatar Jul 19 '22 20:07 psampathkumar

It's a checkable button. The issue is that none of the themes implements the appropriate styling.

lmoureaux avatar Aug 13 '22 22:08 lmoureaux

Anyone willing to write some CSS for Classic and Nightstalker?

lmoureaux avatar Aug 26 '22 00:08 lmoureaux

I'd say the tooltip should show the current state, that's how I feel it's usually done. What would appropriate styling be here?

daavko avatar Aug 27 '22 16:08 daavko

It's a checkable button, so it should look raised when unchecked and sunken when checked.

lmoureaux avatar Aug 27 '22 16:08 lmoureaux