freeciv21 icon indicating copy to clipboard operation
freeciv21 copied to clipboard

Use city style of original owner

Open psampathkumar opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe. We currently use the city style of the current owner on all the cities, this makes the cities look monotonous

Describe the solution you'd like Use the city style of original owner

Additional context This works well with #1101 City styles are defined by the ruleset,

[citystyle_european]
name        = _("?citystyle:European")
graphic     = "city.european"
graphic_alt = "-"
citizens_graphic     = "ancient"
citizens_graphic_alt = "generic"
reqs = { "type", "name", "range"
         "Style", "European", "Player"
       }

Change the range of Style to support Local and define "Style", "European", "Local" to refer to the original owner or use nationality requirements.cpp:3050

psampathkumar avatar Jul 10 '22 21:07 psampathkumar

Make sure that this does not break music support as it relies on the city style in early game.

jwrober avatar Jul 13 '22 19:07 jwrober

https://github.com/freeciv/freeciv/commit/39e2ee6f46d42b2d58582790881059e40ce153b6

https://hostedredmine.plan.io/issues/870139

psampathkumar avatar Sep 15 '22 14:09 psampathkumar