Quanzheng Long comments

Results 167 comments of


                                            Quanzheng Long

[Proposal] New way to write workflow using Temporal

@ccl0326 yeah I have started the project https://docs.google.com/document/d/1BpJuHf67ibaOWmN_uWw_pbrBVyb6U1PILXyzohxA5Ms/edit

Java 17 support - Illegal reflective access in CustomThrowableTypeAdapter and CheckedExceptionWrapper

It seems like there are some standard replacements recommended. Would you like to propose some changes to that?

[BUG] ManualActivityCompletionClientImpl#fail does not set activityId which causes NPE

I will take a look.

Update apache thrift version in cadence client library

Hi Cadence is moving towards gRPC and it’ll almost there. After migrate to gRPC you can turn off the thrift/tChannel ports. There will be a period that we will support...

Replay should also check & compare if the decision results are the same

^ this means that changing the timer value or activity input type will not break determinism check.

Remove legacy code that execute activity with retryOption but without server side retry

It will throw error like: ``` java.lang.IllegalArgumentException: No value found for mutableSideEffectId=17eb87a3-bbd5-3310-b2c5-48ac24000057, during replay it usually indicates a different workflow runId than the original one at com.uber.cadence.internal.sync.SyncDecisionContext.mutableSideEffect(SyncDecisionContext.java:557) at com.uber.cadence.internal.sync.WorkflowInternal.mutableSideEffect(WorkflowInternal.java:277) at...

Quanzheng Long