longhorn-ui icon indicating copy to clipboard operation
longhorn-ui copied to clipboard

Strange placeholder behaviour in input field

Open votdev opened this issue 1 year ago • 3 comments

Replace it’s with it is because the apostrophe is rendered with a big space with the configured AvenirNext-Regular font-family. This is the only occurrence of it’s in the whole UI, everywhere else it is is used. Perhaps for certain reasons.

Which issue(s) this PR fixes:

https://github.com/longhorn/longhorn/issues/7917

votdev avatar Feb 13 '24 14:02 votdev

It seems to be an env situation with the font. I see that the list of fonts goes for a bit and not sure if this is Antd configuration but we might be able to re-write it and use something more generic if Avenir is missing.

AvenirNext-Regular, "Helvetica Neue", "lucida grande", PingFangHK-Light, STHeiti, "Heiti SC", "Hiragino Sans GB", "Microsoft JhengHei", "Microsoft Yahei", SimHei, "WenQuanYi Micro Hei", "Droid Sans", Roboto, Helvetica, Tahoma, Arial, "sans-serif"

It renders Ok on MacOS image

scures avatar Feb 13 '24 14:02 scures

It seems to be an env situation with the font. I see that the list of fonts goes for a bit and not sure if this is Antd configuration but we might be able to re-write it and use something more generic if Avenir is missing.

AvenirNext-Regular, "Helvetica Neue", "lucida grande", PingFangHK-Light, STHeiti, "Heiti SC", "Hiragino Sans GB", "Microsoft JhengHei", "Microsoft Yahei", SimHei, "WenQuanYi Micro Hei", "Droid Sans", Roboto, Helvetica, Tahoma, Arial, "sans-serif"

It renders Ok on MacOS image

Adapting the font might be another solution. But as mentioned above, i've not found any other use of an apostrophe in the messages. For this reason, I vote in favour of the replacement, as this change also has much less impact on the rest of the UI.

votdev avatar Feb 14 '24 11:02 votdev

@votdev can you rebase master? It might fix the codespell gate.

scures avatar Mar 19 '24 10:03 scures

Test on the latest Chrome, firefox and edge can't reproduce this issue. Looks like the browser font issue. But it's okay to minor replace it's to it is.

@votdev , could you rebase with master ? then I can approve and merge.

a110605 avatar Jun 18 '24 03:06 a110605