longhorn-manager
longhorn-manager copied to clipboard
chore(vendor): update go-common-libs/go-iscsi-helper and resolve breaking changes
ref: https://github.com/longhorn/longhorn/issues/7960
Update dependencis and resolve the breaking changes.
- go-iscsi-helper
- go-common-libs
The PR is mainly based on this PR https://github.com/longhorn/longhorn-manager/pull/2103/files Talos support is not backported to v1.5.x. But we did some refactors on the common libs at the same time So those refactors were not backported as well.
I am thinking maybe in the future, refactors can be in separated PR so we can backport those refactors immediately.
Depends on PRs:
longhorn-engine: https://github.com/longhorn/longhorn-engine/pull/1050longhorn-instance-manager: https://github.com/longhorn/longhorn-instance-manager/pull/434longhorn-share-manager: https://github.com/longhorn/longhorn-share-manager/pull/155
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏
Fixed.
I am thinking maybe in the future, refactors can be in separated PR so we can backport those refactors immediately.
Sounds good.