Lu Zhang comments

Results 44 comments of


                                            Lu Zhang

ignore rpc errors when collecting validator responses

> > This won't tolerate f byzantine nodes in the system, unfortunately. The f byzantine nodes can send back non-retryable errors for every tx they receive. > > There won't...

[bridge 15/n] handle sui tx digest

cc @jayfromthe13th

[bridge] rename `TokenBridgeEvent` to `TokenDepositedEvent` and remove the message_type field

> @longbowlu does this mean `message_type` is removed everywhere? including the inner bridge token transfer record table? no just this event type

[bridge] rename `TokenBridgeEvent` to `TokenDepositedEvent` and remove the message_type field

@dariorussi in case you missed it, this PR fixed some stuff we walked through in the event discussion

[bridge 14/n] simple handle_eth_tx_hash

cc @Jayfromthe13th

[bridge 13/n] wire up orchestrator and action executor

cc @Jayfromthe13th

[native bridge smart contract 2/n] - Add Bridge package to Sui framework

> > Is this PR trying to both add a new package and creating new bridge objects? Is there a reason they have to be in the same PR? It...

[native bridge smart contract 2/n] - Add Bridge package to Sui framework

Looks good overall! left some questions about best practices. Would love @lxfind @mystenmark and @amnn 's review if possible

[native bridge smart contract 2/n] - Add Bridge package to Sui framework

> Overall the bridge object creation logic looks ok. Main thing I want to understand is what the chain id is, and where it comes from. this is [chain id...

[native bridge smart contract 2/n] - Add Bridge package to Sui framework

> @tnowacki whats the current state of how we rollout framework changes to mainnet, as in if we land this will this go out to mainnet in 2 weeks? If...