jquery-date-range-picker icon indicating copy to clipboard operation
jquery-date-range-picker copied to clipboard

Calendar does not show greyed dates from next/previous month

Open vishnuvardan opened this issue 8 years ago • 7 comments

The following is the screenshot taken from demo page http://longbill.github.io/jquery-date-range-picker/. It does not show the dates from other month. image

Image from GitHub page shows disabled dates from other month: image

vishnuvardan avatar Sep 01 '16 07:09 vishnuvardan

Mm, indeed, apparently default behavior has changed.

It seems there is an inconsistency between the CSS classes, here they are 'set':

https://github.com/longbill/jquery-date-range-picker/blob/eb4f79b459ec6fd65490f0d08e82bc20a2722a0c/src/daterangepicker.css#L94-L99

And here they are set to 'nodisplay': https://github.com/longbill/jquery-date-range-picker/blob/eb4f79b459ec6fd65490f0d08e82bc20a2722a0c/src/daterangepicker.css#L125-L126

Not sure why that last part is done. Anyone?

holtkamp avatar Sep 01 '16 08:09 holtkamp

Wow, thank you so much Menno Holtkamp :) You saved my day :) Added the tweak for us :)

I am completely satisfied for the response. You can close the bug :)

vishnuvardan avatar Sep 01 '16 09:09 vishnuvardan

It seems this advice https://github.com/longbill/jquery-date-range-picker/issues/38 has entered the repository using https://github.com/longbill/jquery-date-range-picker/commit/ad8aa84e0396a2baacbdfe6e89002d317829e84e

@longbill remember why you did this?

holtkamp avatar Sep 01 '16 09:09 holtkamp

This still seems to be in the codebase. Did you ever got a response to this, @holtkamp?

hbulens avatar Oct 21 '22 09:10 hbulens

@hbulens nope. Maybe we should make this configurable?

holtkamp avatar Oct 21 '22 11:10 holtkamp

That would be the cleanest way, yes. Although it would most definitely suffice to make it visible by default. Google Calendar, Outlook, and others all have those dates visible, so people aren't going to be surprised to see those dates appear in the calendar.

hbulens avatar Oct 21 '22 11:10 hbulens

I agree that displaying the dates of other months in greyed out approach seems like an accepted default mode.

@hbulens feel free to open a Pull Request.

Disclaimer: not sure if I will be able to release a new version, @monovertex released the last releases...

holtkamp avatar Oct 21 '22 12:10 holtkamp