fastapi-limiter icon indicating copy to clipboard operation
fastapi-limiter copied to clipboard

Update call to redis.evalsha for aoiredis v2

Open hardbyte opened this issue 3 years ago • 8 comments

Closes #16 Related to #14

hardbyte avatar Aug 10 '21 22:08 hardbyte

@long2ice any chance you could merge and release with this? The latest versions of fastapi and fastapi-limiter don't work together!

hardbyte avatar Aug 19 '21 07:08 hardbyte

I've rebased so there are no merge conflicts.

hardbyte avatar Sep 01 '21 23:09 hardbyte

@hardbyte @long2ice any update when is this going to merge?

ssinghgc avatar Oct 31 '21 07:10 ssinghgc

Hello, we really need that patch. Any update when is this going to merge?

heavenboy8 avatar Dec 20 '21 11:12 heavenboy8

@hardbyte @long2ice can we please get this merged. This is such a great and useful package but it has been sitting unusable for 8 months. If there's anything that needs to be done I'm happy to help but it looks like we just need a new release.

rbracco avatar Apr 04 '22 13:04 rbracco

@rbracco use the git repo instead of PyPi, for some reason @long2ice has still not pushed the new version to PyPi

Edit: The bug is not present on 0.1.5 and is occurring when using 0.1.4 with aioredis 2

divadsn avatar Apr 05 '22 06:04 divadsn

@long2ice Also looking forward to a new release! Thanks!

rowrowrowrow avatar Jul 22 '22 20:07 rowrowrowrow

What happen to this?

Anyone knows an alternative for this suitable for fastapi?

alanredmaiar avatar Sep 13 '22 08:09 alanredmaiar

What happen to this?

Anyone knows an alternative for this suitable for fastapi?

Use the git repo, it works just fine...

https://github.com/divadsn/geoip-api/blob/master/requirements.txt#L3

divadsn avatar Sep 24 '22 04:09 divadsn

when can we merge this pr?

morestart avatar Oct 06 '22 09:10 morestart

By the way, aioredis seems to migrate to redis-py. https://github.com/aio-libs/aioredis-py Wouldn't it be wiser to user redis-py instead?

LifeforDream avatar Nov 24 '22 08:11 LifeforDream

Fixed already

long2ice avatar Nov 24 '22 08:11 long2ice