asynch icon indicating copy to clipboard operation
asynch copied to clipboard

Add (U)?Int(128|256) integer types.

Open palkeo opened this issue 3 years ago • 2 comments

I had to implement read_items/write_items given that this size of integers is not supported by Python's struct.

Not sure it's ideal to have these new types transitively inherit from FormatColumn, but I wanted to keep the check_items/before_write_items, and this works fine.

palkeo avatar Jun 30 '22 18:06 palkeo

Thanks! Please add unittests about this.

long2ice avatar Jul 01 '22 00:07 long2ice

Done.

palkeo avatar Jul 01 '22 16:07 palkeo

@long2ice when it will be merged?

randomowo avatar Oct 31 '22 20:10 randomowo

Thanks! Looks like ci was failed

long2ice avatar Nov 02 '22 03:11 long2ice

Thanks! Please rebase dev and make ci pass

long2ice avatar Nov 08 '22 01:11 long2ice

i thing using asserts in Big(U)IntColumn is a bad idea if only because if you use python with -O flag asserts would not work.

randomowo avatar Nov 08 '22 09:11 randomowo

@palkeo @long2ice is that okey if i reopen this (and #45) pr from my fork for faster merge?

randomowo avatar Nov 08 '22 13:11 randomowo

@randomowo That's good

long2ice avatar Nov 08 '22 13:11 long2ice

#57

randomowo avatar Nov 08 '22 13:11 randomowo