Fix default port on secure connection + Query Parameterization
I found and fixed 2 bugs:
- when creating a secure
Connectionwithout specifying the port, it default to9000even though there's logic to handle it. - Query parameterization seemed broken, there where no tests and it was using a mix of methods for string formatting that doesn't mix (% formatting with dict as the specifier): I changed it to be inline with the functions logic (using
.format()with a dict)
@DaniilAnichin , @pohmelie, hello :wave: .
Could you possibly review this PR?
@barakor , hello. Any updates? Are you willing to drag this PR to the finish line?
hello. Any updates? Are you willing to drag this PR to the finish line?
What's missing @stankudrow ? I thought I addressed everything
hello. Any updates? Are you willing to drag this PR to the finish line?
What's missing @stankudrow ? I thought I addressed everything
Added new suggestions and outlined the existent.
Also, is this case is implemented in a unit test?
@barakor , hello.
Please consider rebasing after the #141 and it would be very kind if you let us know when it is done so we could finalise this PR.