asynch icon indicating copy to clipboard operation
asynch copied to clipboard

Fix default port on secure connection + Query Parameterization

Open barakor opened this issue 7 months ago • 5 comments

I found and fixed 2 bugs:

  • when creating a secure Connection without specifying the port, it default to 9000 even though there's logic to handle it.
  • Query parameterization seemed broken, there where no tests and it was using a mix of methods for string formatting that doesn't mix (% formatting with dict as the specifier): I changed it to be inline with the functions logic (using .format() with a dict)

barakor avatar May 21 '25 09:05 barakor

@DaniilAnichin , @pohmelie, hello :wave: .

Could you possibly review this PR?

stankudrow avatar May 26 '25 14:05 stankudrow

@barakor , hello. Any updates? Are you willing to drag this PR to the finish line?

stankudrow avatar Jun 18 '25 16:06 stankudrow

hello. Any updates? Are you willing to drag this PR to the finish line?

What's missing @stankudrow ? I thought I addressed everything

barakor avatar Jun 18 '25 16:06 barakor

hello. Any updates? Are you willing to drag this PR to the finish line?

What's missing @stankudrow ? I thought I addressed everything

Added new suggestions and outlined the existent.

Also, is this case is implemented in a unit test?

stankudrow avatar Jun 19 '25 15:06 stankudrow

@barakor , hello.

Please consider rebasing after the #141 and it would be very kind if you let us know when it is done so we could finalise this PR.

stankudrow avatar Nov 06 '25 18:11 stankudrow