asynch icon indicating copy to clipboard operation
asynch copied to clipboard

Remove the bare except statement from the Cursor's fetchone method.

Open stankudrow opened this issue 1 year ago • 4 comments

Resolves the issue #117 .

stankudrow avatar Oct 12 '24 12:10 stankudrow

@llchan, could you possibly review this PR and approve if you like it?

@long2ice , hello, it is up to you whether to merge this PR before the new asynch release or after (relates to the issue #116 ).

Thank you all in advance.

stankudrow avatar Oct 12 '24 12:10 stankudrow

@long2ice , @llchan, any suggestions?

stankudrow avatar Oct 14 '24 19:10 stankudrow

LGTM. It may be better to tighten in the future but this at least addresses my concerns about signals getting discarded. I don't think I can approve/merge the PR though so we still need to wait for a maintainer.

llchan avatar Oct 14 '24 20:10 llchan

LGTM. It may be better to tighten in the future but this at least addresses my concerns about signals getting discarded. I don't think I can approve/merge the PR though so we still need to wait for a maintainer.

You have already expressed your support, thank you. Could you share your ideas on tiding and suggestions about future improvements?

stankudrow avatar Oct 15 '24 05:10 stankudrow

@llchan , done in the #119 , you can close the issue #118 .

stankudrow avatar Oct 17 '24 07:10 stankudrow