Joshua Pan

Results 9 comments of Joshua Pan

That can be changed pretty easily :) You can start a topic on czo. Sent from mobile. Please excuse any typos. On Sun, Jun 3, 2018, 9:55 AM Anupam Dagar...

This fixes #6581. Can you add `Fixes #6581.` to the end of the commit message?

@Cito thanks for the quick reply! Yes, we are using the latest version of GraphQL-core. We can't share our schema explicitly, but I wrote a script that creates a schema...

Interesting that the speedup is that large with PyPy 3.6. I myself profiled the GraphQL execution code, but also couldn't come up with any obvious bottlenecks. Hopefully others can look...

Yea, I don't think there's currently a way to disable inactivity checks for a certain repo.

Can't we just implement (test on the test repo with zulipbot-test) and just have @timabbott run the code with zulipbot on zulip repos?

It should mean 20+ commits in Zulip repos. However you should ask on Zulip to double check with Rishi @rishig Sent from mobile. Please excuse any typos. On Feb 19,...

Here's the test that I wrote: ```diff diff --git a/frontend_tests/node_tests/activity.js b/frontend_tests/node_tests/activity.js index ca5e901..dd52606 100644 --- a/frontend_tests/node_tests/activity.js +++ b/frontend_tests/node_tests/activity.js @@ -857,4 +857,18 @@ run_test('initialize', () => { }; activity.initialize(); + +...

For the mongoose promise, I just did `mongoose.Promise = global.Promise;`