ent icon indicating copy to clipboard operation
ent copied to clipboard

tranformWrite follow-ups

Open lolopinto opened this issue 1 year ago • 1 comments

  • createdAt shouldn't be changed in a create -> edit https://github.com/lolopinto/ent/blob/c43485039c8614d65291c290d6824a8b98332125/examples/simple/src/ent/tests/auth_code.test.ts#L68
  • maybe type Data so it matches input? is that a breaking change?
  • definitely throw if data is a Map. that's definitely not what we want
  • validate that any key returned in data is an inputKey or storageKey of schemaFields and throw if an unexpected key is found
    • it wasn't working for userID in auth code example so checked for both inputKey and storageKey of fieldInfo but that means we could be sending extra and ignoring it now

follow-up to https://github.com/lolopinto/ent/issues/1765

lolopinto avatar Mar 02 '24 06:03 lolopinto

also: documentation for data passed in see https://github.com/lolopinto/ent/issues/1764

lolopinto avatar Mar 02 '24 06:03 lolopinto