OneList icon indicating copy to clipboard operation
OneList copied to clipboard

[WIP] Feature/13/homescreenwidget v2

Open newhinton opened this issue 4 years ago • 6 comments

see #15

newhinton avatar Apr 02 '20 13:04 newhinton

Currently this does not support Lists stored on the internal storage

Edit: It seems that was due to a corrupted file

newhinton avatar Apr 02 '20 14:04 newhinton

Todo:

  • [ ] Configurationscreen Overhaul
  • [ ] List reordering
  • [ ] List switching

newhinton avatar Apr 04 '20 15:04 newhinton

Just tested it, works as expected so far :) Thanks ! I just fixed List reordering. Can you allow me to push on your PR ? https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

lolo-io avatar Apr 11 '20 17:04 lolo-io

Or if you prefer I can do a PR on your fork. Which do you prefer ?

lolo-io avatar Apr 12 '20 17:04 lolo-io

@lolo-io you should already be able to make edits to this branch, as per link you posted maintainers should be able to make edits

newhinton avatar Apr 12 '20 22:04 newhinton

Yes my bad the rejected push was due to a bad github config on my side. I've pushed list reordering on your pr branch. I use the same code that is used to reorder lists when an item is checked/unchecked within the app. I have refactored it as a fiunction of ListItem.

lolo-io avatar Apr 13 '20 12:04 lolo-io