mill-scalablytyped icon indicating copy to clipboard operation
mill-scalablytyped copied to clipboard

scalablyTypedBasePath default

Open ajrnz opened this issue 2 years ago • 2 comments

Would it make more sense for scalablyTypedBasePath to default to millSourcePath / os.up instead of T.workspace?

Currently if you use mill-scalablytyped in a sub or foreign module it will look in the root module for the package.json.

However if you are trying to wrap JS libs it will look in the root project which ruins the encapsulation. I defer to you superior JavaScript knowledge in this. I can work around by:

def scalablyTypedBasePath = T{ millSourcePath / os.up }

(This is effectively T.workspace in a simple project)

ajrnz avatar Nov 30 '22 16:11 ajrnz