plexrequests-meteor
plexrequests-meteor copied to clipboard
lokenx
[FEATURE REQUEST] Change language of the menus
I can help translate it for portuguese if necessary.
Is there a chance we can get this working? Of course it would still be up to volunteers to do the translation to other languages but it would be nice if there was a way someone could just contribute and the new language get added.
But I'm willing to do the translation already! Is there any interest in adding this option?
That's a great idea! And I'm ashamed not having thought if it before lol.
That said, it will take quite a bit of work since all the text is hard coded and then there's the matter of search results. I'll look into it this week to get an idea of what all is needed to get this working.
On Tue, Nov 7, 2017, 6:40 AM Nottt [email protected] wrote:
I can help translate it for portuguese if necessary.
Is there a chance we can get this working? Of course it would still be up to volunteers to do the translation to other languages but it would be nice if there was a way someone could just contribute and the new language get added.
But I'm willing to do the translation already! Is there any interest in adding this option?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lokenx/plexrequests-meteor/issues/507, or mute the thread https://github.com/notifications/unsubscribe-auth/AQbPDWpieTgEq-GGheHr2z5WG7Igjrfaks5s0E-hgaJpZM4QUugo .
I don't mind English, but my users don't speak english :(
Can't you make something like, I translate the text and make it a .zip file that you then load it and overwrite the hard-coded stuff?
Also the search results, if you are only pulling from sonarr/radarr they both let you search using foreign names since their databases have both names usually. But I could tell my users to just google the english name. And based on the poster / movie name they would be able to add what they want at least.
It seems you are using themoviedb right? I can search movies using foreign names just fine. So you should be fine most of the time...
It'll work something like that, it's not so much that the implementation is hard or anything, there's just quite a bit of text that would need to changed from hard coded.
Regarding search results, we directly search TVMaze and TMDB using their API's. I'll need to look at their documentation to see if they have the option to set the locale or not and work that into the fold if so. If they don't then yeah, we'll be limited to using English for search.
On Tue, Nov 7, 2017, 7:06 AM Nottt [email protected] wrote:
I don't mind English, but my users don't speak english :(
Can't you make something like, I translate the text and make it a .zip file that you then load it and overwrite the hard-coded stuff?
Also the search results, if you are only pulling from sonarr/radarr they both let you search using foreign names since their databases have both names usually. But I could tell my users to just google the english name. And based on the poster / movie name they would be able to add what they want at least.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lokenx/plexrequests-meteor/issues/507#issuecomment-342476379, or mute the thread https://github.com/notifications/unsubscribe-auth/AQbPDawQA426fZLzolLgaE-EttSMvs9dks5s0FXMgaJpZM4QUugo .
@rigrassm well the priority right now should be make the menus accessible to non-english people. If both radarr and sonar can search using foreign titles so can you probably.
Let me know when I can help start translating and hopefully you won't lose interest on this :P