php-lokalise-api icon indicating copy to clipboard operation
php-lokalise-api copied to clipboard

Do not use "list" as method name

Open jeremiegrenier opened this issue 3 years ago • 1 comments

All classes in the "API" namespace have a method named "list".

This causes an error lower to PHP5.6: Tag 3.0.0 is allowed to work with php5.6 but have "list"

PHP Parse error:  syntax error, unexpected 'list' (T_LIST), expecting '('

Because "list" is a keyword in PHP, it could not be used as a method name.

See Documentation

jeremiegrenier avatar Feb 14 '22 11:02 jeremiegrenier

php 5.6 moved long ago to end of life. See: https://www.php.net/supported-versions.php. Please move on, there is no benefit to keep supporting such old versions, rather a slow down of progress.

If the maintainer is up for that, submit a pull request based on 3.1.0 to push a legacy release 3.x.x?

TheLevti avatar Nov 10 '22 21:11 TheLevti