Loïc Rouchon
Loïc Rouchon
@tomazfernandes , this is a way bigger scope than I initially intended, but I do see the value for it. I'll work on something along those lines. > If the...
More questions around the BatchAwareBackPressureHandler. The behavior of the SemaphoreBPH#requestBatch method is not equivalent to calling request(batchSize). This means in order to keep the current behavior of the SemaphoreBPH when...
Hi again @tomazfernandes, Few observations I made while digging into it today (please let me know if I got one wrong): * `BPH#request(int amount)` method is never called in the...
Hey @tomazfernandes, thanks for your inputs. I was able to resume and accommodate most of your comments (I think). I managed to implement the `CompositeBackPressureHandler` but in order to allow...
Hey @tomazfernandes, thanks for the feedback > 1. We must be mindful of breaking changes - we can't remove methods or interfaces. We can deprecate them instead, and / or...
Hey @tomazfernandes, thanks for the insightful comments. And no worries for the delay, this week it is me having a low availability. But I hope I’ll have time to work...
Hi @tomazfernandes! I got a bit of time this week and I did experiment with a non blocking (without semaphore) BPH. Here is what is part of the latest push:...
Hey @tomazfernandes, I was able to make some progress on some of the topics, here is the current status > The test cases with NonBlockingExternalConcurrencyLimiterBackPressureHandler look great! I think we...
Hello @tomazfernandes, I performed some updates regarding the backward compatibility. Here's the summary. **BackPressureHandler interface**: * The new method `void release(int amount, ReleaseReason reason)` is now default and calls `release(amount)`....
Hello @tomazfernandes, I performed some additional updates as per your suggestion and I think I managed to split the SemaphoreBackPressureHandler into two separated BackPressureHandler: a `ConcurrencyLimiterBlockingBackPressureHandler` and a `ThroughputBackPressureHandler`. The...