BaGet icon indicating copy to clipboard operation
BaGet copied to clipboard

Add support for MiniO storage backend

Open alfeg opened this issue 3 years ago • 6 comments

This PR is yet another attempt to address #621, #551, and #271

Added additional settings to S3StorageOptions:

  • ForcePathStyle = false setting to true will make AWSSDK.net compatible with MiniO installations
  • ServiceUrl - ability to override S3 service location
  • UseHttp - ability to use HTTP protocol for ServiceUrl

All those settings are real settings from actual AmazonS3Config from official AWSSDK library

There is already another PR's to address those issues: https://github.com/loic-sharma/BaGet/pull/644 and https://github.com/loic-sharma/BaGet/pull/272

My PR is much less intrusive, only adding ability to pass settings that are already exists in AwsSdk library

alfeg avatar Jul 14 '21 07:07 alfeg

@loic-sharma Can you please add this? I like BaGet but would like to use MinIO as storage backend in my kubernetes cluster instead of nfs.

viceice avatar Sep 20 '21 15:09 viceice

Hello @alfeg, thank you for the contribution! Your changes look good. I suggested some minor tweaks but I've never used MinIO. Could you let me know what you think?

@viceice and @DTeuchert Feel free to jump in too if you have comments!

loic-sharma avatar Sep 25 '21 17:09 loic-sharma

Hello @alfeg, thank you for the contribution! Your changes look good. I suggested some minor tweaks but I've never used MinIO. Could you let me know what you think?

Hello,

I'm OK with all proposed changes, but cannot test them in any way for next two weeks. I'm on vacation without laptop and with poor internet :)

alfeg avatar Sep 25 '21 17:09 alfeg

On Monday I can test this request with a ceph cluster as s3 backend.

DTeuchert avatar Sep 25 '21 18:09 DTeuchert

are there any plans on following up on this ?

krmxd avatar May 03 '24 07:05 krmxd

you should check

  • https://github.com/bagetter/BaGetter

viceice avatar May 04 '24 12:05 viceice